Skip to content

fix(compile): normalize legacy Azure Repos remotes#1495

Merged
jamesadevine merged 2 commits into
mainfrom
copilot/agent-issue-normalize-azure-repos-remotes
Jul 13, 2026
Merged

fix(compile): normalize legacy Azure Repos remotes#1495
jamesadevine merged 2 commits into
mainfrom
copilot/agent-issue-normalize-azure-repos-remotes

Conversation

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Equivalent Azure Repos remotes could compile to different integrity locks when the local origin used the legacy visualstudio.com/DefaultCollection shape. That left ado-aw-metadata / aw_info.json source identity empty locally but populated in Azure Pipelines, causing deterministic integrity checks to fail.

  • Remote normalization

    • Accepts legacy collection-prefixed remotes:
      https://{org}.visualstudio.com/DefaultCollection/{project}/_git/{repo}
      
    • Canonicalizes them to the same context as:
      https://dev.azure.com/{org}/{project}/_git/{repo}
      
    • Covers both parse_ado_remote() and parse_git_remote().
  • Integrity regression coverage

    • Compiles the same workflow from temp git repos using legacy and modern Azure Repos remotes.
    • Asserts complete lock output is byte-identical and source metadata is populated.
  • Failure-signal cleanup

    • Preserves ADO’s implicit success gate on trigger-conditioned execution-context steps:
      condition: and(succeeded(), <trigger predicate>)
    • Applies to PR, PR checks, work item, schedule, CI push, pipeline, and manual context steps.

Test plan

  • cargo build
  • cargo test
  • cargo clippy --all-targets --all-features

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot AI changed the title [WIP] Normalize legacy Azure Repos remotes for deterministic integrity locks fix(compile): normalize legacy Azure Repos remotes Jul 13, 2026
Copilot AI requested a review from jamesadevine July 13, 2026 15:29
@jamesadevine
jamesadevine marked this pull request as ready for review July 13, 2026 15:30
@jamesadevine
jamesadevine merged commit 928cd59 into main Jul 13, 2026
31 of 36 checks passed
@jamesadevine
jamesadevine deleted the copilot/agent-issue-normalize-azure-repos-remotes branch July 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent-issue]: normalize legacy Azure Repos remotes for deterministic integrity locks

2 participants